www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] configure.ac: Add --with-crypto= instead of many different --with-$backend

Re: [PATCH] configure.ac: Add --with-crypto= instead of many different --with-$backend

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Tue, 08 Nov 2016 17:31:36 +0100

On Monday, November 07, 2016 03:34:27 Peter Stuge wrote:
> The new --with-crypto option replaces the previous backend-specific
> --with-{openssl,libgcrypt,mbedtls,wincng} options and fixes some issues.
>
> * libgcrypt or mbedtls would previously be used whenever found, even
> if configure was passed --without-libgcrypt or --without-mbedtls.
>
> * If --with-$backend was specified then configure would not fail even
> if that library could not be found, and would instead use whichever
> crypto library was found first.
>
> The new option defaults to `auto`, which makes configure check for all
> supported crypto libraries in turn, choosing the first one found, or
> exiting with an error if none can be found.

This patch seems to break detection of EVP_aes_128_ctr() while building
against OpenSSL. This is the corresponding part of config.log with the
current master branch:

  configure:16982: checking for EVP_aes_128_ctr
  configure:16982: gcc -o conftest -g -O2 conftest.c -lssl -lcrypto >&5
  configure:16982: $? = 0
  configure:16982: result: yes

But with this patch applied, it looks like this:

  configure:14772: checking for EVP_aes_128_ctr
  configure:14772: gcc -o conftest -g -O2 conftest.c >&5
  /tmp/ccARmUY4.o: In function `main':
  conftest.c:60: undefined reference to `EVP_aes_128_ctr'
  collect2: error: ld returned 1 exit status
  configure:14772: $? = 1

Kamil
_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2016-11-08

the libssh2 team