www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: Allow authentication to be passed in memory - blast from the past

Re: Allow authentication to be passed in memory - blast from the past

From: David Calavera <david.calavera_at_gmail.com>
Date: Mon, 1 Sep 2014 20:58:38 -0700

I cleaned up some warnings that I detected and put together another patch:

https://github.com/calavera/libssh2/commit/2b75806bc60116af5b834508abc9bfc3a9039cb5.patch

I also created a macro for the initial prototype:

+#define libssh2_userauth_publickey_frommemory(session, username, publickey, \
+ privatekey, passphrase) \
+ libssh2_userauth_publickey_frommemory_ex((session), (username), \
+ (unsigned int)strlen(username), \
+ (publickey), \
+ (unsigned int)strlen(publickey), \
+ (privatekey), \
+ (unsigned int)strlen(privatekey), \
+ (passphrase))

I just realized that I didn't apply the changes for the documentation of
this new authentication. I'll add it shortly.

I'd really appreciate some feedback.

Cheers,
David

On Mon, Sep 1, 2014 at 4:06 PM, David Calavera <david.calavera_at_gmail.com>
wrote:

> Hi,
>
> I was doing some digging to see how I could pass auth keys by memory when
> I discovered this old thread from 2012 with a patch:
>
> http://www.libssh2.org/mail/libssh2-devel-archive-2012-01/0015.shtml
>
> I'm really interested in seeing this incorporated to libssh2, so I decided to try to address the problems raised in the next message in that thread:
>
> http://www.libssh2.org/mail/libssh2-devel-archive-2012-01/0016.shtml
>
> I created a new patch that addressed part those points. You can see it at:
>
>
> https://github.com/calavera/libssh2/commit/d083300c69f41eff6132da3525722fc590e350cf.patch
>
> I replaced the use of `memcpy_s` to use `memcpy`. I also formatted the
> code to use less that 80 columns.
>
> I ran `./configure --enable-debug` to try to address the warnings in the
> code, but unfortunately I didn't get any. I'm not sure if I'm doing
> anything wrong, I posted the output here:
>
> https://gist.github.com/calavera/639002dd56753640721d
>
> I'd really appreciate if anybody could point me to those warnings if there
> is anything I'm missing.
>
> As I said, I'm really interested in seeing this merged into libssh2.
> Please, let me know if there is anything else I can help with to make that
> possible.
>
> Cheers,
> David
>
>

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2014-09-02

the libssh2 team