www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples

Archive Index This month's Index

Subject: Re: [PATCH] userauth: Allow authentication keys to be passed in memory

Re: [PATCH] userauth: Allow authentication keys to be passed in memory

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sat, 21 Jan 2012 23:23:38 +0100 (CET)

Hello,

Thanks for the updated patch! This time I applied it, had a look and here are
my comments:

- memcpy_s() is not a function that exists portably, don't use it. I also
   think you can skip checking memcpy()'s return code.

- your new code produces lots of warnings and we're trying hard to not have
   warnings (some are still there but lets not add new ones). ./configure
   --enable-debug helps us see them.

- also, where it is possible please keep the source lines shorter than 80
   columns 

-- 
  / daniel.haxx.se
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2012-01-21

the libssh2 team