Subject: Re: [PATCH] Honour window_size_initial from _libssh2_channel_read

Re: [PATCH] Honour window_size_initial from _libssh2_channel_read

From: Daniel Stenberg <>
Date: Sun, 27 Oct 2013 15:32:14 +0100 (CET)

On Mon, 21 Oct 2013, Salvador Fandino wrote:

> The most controversial change is the way those new parameters are set as I
> have added a new unified interface for setting/retrieving all the session
> parameters "libssh2_session_config_(set|get)" and deprecated
> "libssh2_session_flag" and "libssh2_session_(set|get)_(timeout|blocking)". A
> more detailed explanation is on the commit message.

We did have a discussion before (although I didn't actually bother to try to
find any links to it right now), about what the best API for this kind of
things is, and we then decided on the libssh2_session_(set|get)_[what]

So, I don't think we should deprecate these functions but I'm open for adding
new ones for setting/getting other options and values.

> The alternative would be to use a pair of functions to set/get every
> parameter. I don't have a strong preference for one way or the other. My
> only point is that the API should be consistent in the way those accessors
> work.

I agree that moving everything over to a single consistent way is preferable
and makes it easier for newcomers to find out how to do things.

> In any case, IMO, patches 1 an 2 can be applied right now as they implement
> changes we have already discussed.

They've been merged and pushed now. thanks!

Received on 2013-10-27