Subject: Re: [PATCH] Honour window_size_initial from _libssh2_channel_read

Re: [PATCH] Honour window_size_initial from _libssh2_channel_read

From: Salvador Fandino <>
Date: Mon, 28 Oct 2013 18:55:01 +0100

On 10/27/2013 03:32 PM, Daniel Stenberg wrote:
> On Mon, 21 Oct 2013, Salvador Fandino wrote:
>> The most controversial change is the way those new parameters are set
>> as I have added a new unified interface for setting/retrieving all the
>> session parameters "libssh2_session_config_(set|get)" and deprecated
>> "libssh2_session_flag" and
>> "libssh2_session_(set|get)_(timeout|blocking)". A more detailed
>> explanation is on the commit message.
> We did have a discussion before (although I didn't actually bother to
> try to find any links to it right now), about what the best API for this
> kind of things is, and we then decided on the
> libssh2_session_(set|get)_[what] approach.
> So, I don't think we should deprecate these functions but I'm open for
> adding new ones for setting/getting other options and values.

Here there is a new version of the patches adding the
channel_window_size and channel_packet_size slots into the session
object and the corresponding accessors as separate functions.

Received on 2013-10-28