From libssh2-devel-bounces@cool.haxx.se Mon Nov 3 16:27:44 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sA3FRFEC018264; Mon, 3 Nov 2014 16:27:39 +0100 Received: from tux133.hoststar.ch (tux133.hoststar.ch [78.46.64.177]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sA3FRDQI018254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Mon, 3 Nov 2014 16:27:14 +0100 Received: from [192.168.13.80] (84-75-46-38.dclient.hispeed.ch [84.75.46.38]) (authenticated bits=0) by tux133.hoststar.ch (8.13.8/8.12.11) with ESMTP id sA3FRBEi021310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Mon, 3 Nov 2014 16:27:12 +0100 Message-ID: <54579ECF.8030803@heag.ch> Date: Mon, 03 Nov 2014 16:27:11 +0100 From: Erwin Brandenberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: libssh2-devel@cool.haxx.se Subject: libssh2 through squid3 X-Scanned-By: mimedefang-scanned X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sA3FRFEC018264 I like to connect to a SFTP server through a squid3 proxy A test with filezilla seams to work. With my test binary I have troubles. At the handshake I get a -2 as error known as LIBSSH2_ERROR_BANNER_RECV. My code looks like error = libssh2_init (0); ... error = mTCP->Bind(ownip, mPort); ... error = mTCP->Connect(mProxyIp, mProxyPort); ... error = ProxyConnectCommand(mTCP, ip, port, mProxyUser, mProxyPassword); /* HTTP CONNECT method */ ... mSession = libssh2_session_init(); ... /* Since we have set non-blocking, tell libssh2 we are blocking */ libssh2_session_set_blocking((LIBSSH2_SESSION *)mSession, 1); error = libssh2_session_banner_set((LIBSSH2_SESSION *)mSession, "SFTP Client\r\n"); ... #if LIBSSH2_VERSION_NUM >= 0x010208 /* correct method since libssl 1.2.8 */ error = libssh2_session_handshake((LIBSSH2_SESSION *)mSession, mTCP->GetSocket()); #else #endif At this last libssh2_session_handshake call I get the -2 error code: My Log looks like: RWSftpCronThread.cpp(161) 31/10 14:19:30(23)=FTP Client Bind to c0a80d50/0 RWSftpCronThread.cpp(161) 31/10 14:19:30(23)=FTP Client Connect to proxy c0a80d58/3128 RWSftpCronThread.cpp(161) 31/10 14:19:30(23)=FTP Client [Send Proxy Connect]:CONNECT xxx.xxx.xxx.xxx:22 HTTP/1.0 Proxy-authorization: Basic ZXJ3aW46Z29nb2dvMQ== RWSftpCronThread.cpp(161) 31/10 14:19:30(23)=FTP Client [Wait for Proxy Connect Reply]:CONNECT xxx.xxx.xxx.xxx:22 HTTP/1.0 Proxy-authorization: Basic ZXJ3aW46Z29nb2dvMQ== RWSftpCronThread.cpp(161) 31/10 14:19:30(23)=FTP Client [Proxy Reply (200=OK, 401=NeedAuth)]:HTTP/1.1 200 Connection established RWSftpCronThread.cpp(161) 31/10 14:19:30(23)=FTP Client Initialize ssh session RWSftpCronThread.cpp(170) 31/10 14:19:30(13)=FTP Client ErrorTcpBase - Code: -2, Msg: Failure establishing SFTP session Any hint ? _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Nov 3 18:39:38 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sA3HdNOV006047; Mon, 3 Nov 2014 18:39:35 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sA3HcNTs005378 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 3 Nov 2014 18:38:24 +0100 Received: (qmail 26693 invoked by uid 501); 3 Nov 2014 17:38:24 -0000 Message-ID: <20141103173824.26692.qmail@stuge.se> Date: Mon, 3 Nov 2014 18:38:24 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: libssh2 through squid3 Mail-Followup-To: libssh2-devel@cool.haxx.se References: <54579ECF.8030803@heag.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <54579ECF.8030803@heag.ch> X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sA3HdNOV006047 Erwin Brandenberger wrote: > error = libssh2_session_banner_set((LIBSSH2_SESSION *)mSession, "SFTP Client\r\n"); I'm not sure if this is really neccessary or helpful or even harmful. Otherwise the code looks fine. > RWSftpCronThread.cpp(161) 31/10 14:19:30(23)=FTP Client [Proxy Reply > (200=OK, 401=NeedAuth)]:HTTP/1.1 200 Connection established > > RWSftpCronThread.cpp(161) 31/10 14:19:30(23)=FTP Client Initialize ssh > session So far so good. > RWSftpCronThread.cpp(170) 31/10 14:19:30(13)=FTP Client ErrorTcpBase - > Code: -2, Msg: Failure establishing SFTP session We didn't write ErrorTcpBase so it's difficult to say what -2 means. Anyway, it would be very helpful if you care to build libssh2 with debugging enabled, and add a call to libssh2_trace(~0); in your code before the above error happens. You will get copious output. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Nov 4 10:08:22 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sA497t2K022024; Tue, 4 Nov 2014 10:08:17 +0100 Received: from mailrelay11.public.one.com (mailrelay11.public.one.com [195.47.247.189]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sA497rfK021941 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 4 Nov 2014 10:07:54 +0100 X-HalOne-Cookie: 0799181f74e315207c09c3420385d577e5991f8b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fworld.se; s=20140924; h=from:reply-to:subject:date:message-id:to:mime-version:content-type; bh=CAyr9QEjdsvtcfb39kl1nXaCnC201uAGzqtCQK3Ho+U=; b=yrxw7AfFrkg0eDnlh56PlxKN5tkC4c+tYoW91NpyfHOYjFylJHjZNY9/0TRM3bNjE5beKBLKu5Nhw XalK7aVBk/KTEXMoUtIlXErX+fouhmXSSWrcJ+apsUld3aGNCI1533TvAk5CxH49/tsKHkqdpByysB iNGTjrvWr5JAALTo= Received: from webmail7 (unknown [10.246.6.7]) by smtpfilter3.public.one.com (Halon Mail Gateway) with SMTP for ; Tue, 4 Nov 2014 09:06:37 +0000 (GMT) X-Originating-IP: 77.244.10.162 User-Agent: One.com webmail 8.14.0 MIME-Version: 1.0 Message-ID: <1415092066933.16274.248@webmail7> Date: Tue, 04 Nov 2014 09:07:46 GMT To: From: "Frasse" Subject: scp_write example is incomplete. Content-Type: multipart/mixed; boundary="----------246-1415092066933-1" X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: frasse@fworld.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" This is a multipart message in MIME format. ------------246-1415092066933-1 Content-Type: multipart/alternative; boundary="----------246-1415092066933-2" ------------246-1415092066933-2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi. The scp_write example is incomplete. According to the scp spec a completed file transfer should be followed by a= single 0 that the remote machine acknowledge with a status of 0,1 or 2. If= the status is not 0 then an error message can follow ending with a linefee= d. I couldn't understand why I got no indication that my uploads failed when t= he disk on the remote machine was full. The answer was that the code never = requested the acknowledgement. I am attaching a modified version of the example that writes out the error = message to stderr. /Frasse ------------246-1415092066933-2 Content-Type: multipart/related; boundary="----------246-1415092066933-3" ------------246-1415092066933-3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8 Hi.

The scp_write example is incomplete.

According to= the scp spec a completed file transfer should be followed by a single 0 th= at the remote machine acknowledge with a status of 0,1 or 2. If the status = is not 0 then an error message can follow ending with a linefeed.

I couldn't understand why I got no indication that my uploads failed when= the disk on the remote machine was full. The answer was that the code neve= r requested the acknowledgement.

I am attaching a modified versi= on of the example that writes out the error message to stderr.

/= Frasse
------------246-1415092066933-3-- ------------246-1415092066933-2-- ------------246-1415092066933-1 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="example_scp_write.c" Content-Type: text/x-csrc; name="example_scp_write.c" LyoKICogU2FtcGxlIHNob3dpbmcgaG93IHRvIGRvIGFuIFNDUCB1cGxvYWQuCiAqLwoKI2luY2x1 ZGUgImxpYnNzaDJfY29uZmlnLmgiCiNpbmNsdWRlIDxsaWJzc2gyLmg+CgojaWZkZWYgSEFWRV9X SU5TT0NLMl9ICiMgaW5jbHVkZSA8d2luc29jazIuaD4KI2VuZGlmCiNpZmRlZiBIQVZFX1NZU19T T0NLRVRfSAojIGluY2x1ZGUgPHN5cy9zb2NrZXQuaD4KI2VuZGlmCiNpZmRlZiBIQVZFX05FVElO RVRfSU5fSAojIGluY2x1ZGUgPG5ldGluZXQvaW4uaD4KI2VuZGlmCiMgaWZkZWYgSEFWRV9VTklT VERfSAojaW5jbHVkZSA8dW5pc3RkLmg+CiNlbmRpZgojaWZkZWYgSEFWRV9BUlBBX0lORVRfSAoj IGluY2x1ZGUgPGFycGEvaW5ldC5oPgojZW5kaWYKI2lmZGVmIEhBVkVfU1lTX1RJTUVfSAojIGlu Y2x1ZGUgPHN5cy90aW1lLmg+CiNlbmRpZgoKI2luY2x1ZGUgPHN5cy90eXBlcy5oPgojaW5jbHVk ZSA8ZmNudGwuaD4KI2luY2x1ZGUgPGVycm5vLmg+CiNpbmNsdWRlIDxzdGRpby5oPgojaW5jbHVk ZSA8Y3R5cGUuaD4KCmludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCnsKICAgIHVuc2ln bmVkIGxvbmcgaG9zdGFkZHI7CiAgICBpbnQgc29jaywgaSwgYXV0aF9wdyA9IDE7CiAgICBzdHJ1 Y3Qgc29ja2FkZHJfaW4gc2luOwogICAgY29uc3QgY2hhciAqZmluZ2VycHJpbnQ7CiAgICBMSUJT U0gyX1NFU1NJT04gKnNlc3Npb24gPSBOVUxMOwogICAgTElCU1NIMl9DSEFOTkVMICpjaGFubmVs OwogICAgY29uc3QgY2hhciAqdXNlcm5hbWU9InVzZXJuYW1lIjsKICAgIGNvbnN0IGNoYXIgKnBh c3N3b3JkPSJwYXNzd29yZCI7CiAgICBjb25zdCBjaGFyICpsb2NsZmlsZT0ic2NwX3dyaXRlLmMi OwogICAgY29uc3QgY2hhciAqc2NwcGF0aD0iL3RtcC9URVNUIjsKICAgIEZJTEUgKmxvY2FsOwog ICAgaW50IHJjOwogICAgY2hhciBtZW1bMTAyNF07CiAgICBzaXplX3QgbnJlYWQ7CiAgICBjaGFy ICpwdHI7CiAgICBzdHJ1Y3Qgc3RhdCBmaWxlaW5mbzsKCiNpZmRlZiBXSU4zMgogICAgV1NBREFU QSB3c2FkYXRhOwoKICAgIFdTQVN0YXJ0dXAoTUFLRVdPUkQoMiwwKSwgJndzYWRhdGEpOwojZW5k aWYKCiAgICBpZiAoYXJnYyA+IDEpIHsKICAgICAgICBob3N0YWRkciA9IGluZXRfYWRkcihhcmd2 WzFdKTsKICAgIH0gZWxzZSB7CiAgICAgICAgaG9zdGFkZHIgPSBodG9ubCgweDdGMDAwMDAxKTsK ICAgIH0KICAgIGlmIChhcmdjID4gMikgewogICAgICAgIHVzZXJuYW1lID0gYXJndlsyXTsKICAg IH0KICAgIGlmIChhcmdjID4gMykgewogICAgICAgIHBhc3N3b3JkID0gYXJndlszXTsKICAgIH0K ICAgIGlmKGFyZ2MgPiA0KSB7CiAgICAgICAgbG9jbGZpbGUgPSBhcmd2WzRdOwogICAgfQogICAg aWYgKGFyZ2MgPiA1KSB7CiAgICAgICAgc2NwcGF0aCA9IGFyZ3ZbNV07CiAgICB9CgogICAgcmMg PSBsaWJzc2gyX2luaXQgKDApOwogICAgaWYgKHJjICE9IDApIHsKICAgICAgICBmcHJpbnRmIChz dGRlcnIsICJsaWJzc2gyIGluaXRpYWxpemF0aW9uIGZhaWxlZCAoJWQpXG4iLCByYyk7CiAgICAg ICAgcmV0dXJuIDE7CiAgICB9CgogICAgbG9jYWwgPSBmb3Blbihsb2NsZmlsZSwgInJiIik7CiAg ICBpZiAoIWxvY2FsKSB7CiAgICAgICAgZnByaW50ZihzdGRlcnIsICJDYW4ndCBvcGVuIGxvY2Fs IGZpbGUgJXNcbiIsIGxvY2xmaWxlKTsKICAgICAgICByZXR1cm4gLTE7CiAgICB9CgogICAgc3Rh dChsb2NsZmlsZSwgJmZpbGVpbmZvKTsKCiAgICAvKiBVbHRyYSBiYXNpYyAiY29ubmVjdCB0byBw b3J0IDIyIG9uIGxvY2FsaG9zdCIKICAgICAqIFlvdXIgY29kZSBpcyByZXNwb25zaWJsZSBmb3Ig Y3JlYXRpbmcgdGhlIHNvY2tldCBlc3RhYmxpc2hpbmcgdGhlCiAgICAgKiBjb25uZWN0aW9uCiAg ICAgKi8KICAgIHNvY2sgPSBzb2NrZXQoQUZfSU5FVCwgU09DS19TVFJFQU0sIDApOwogICAgaWYo LTEgPT0gc29jaykgewogICAgICAgIGZwcmludGYoc3RkZXJyLCAiZmFpbGVkIHRvIGNyZWF0ZSBz b2NrZXQhXG4iKTsKICAgICAgICByZXR1cm4gLTE7CiAgICB9CgogICAgc2luLnNpbl9mYW1pbHkg PSBBRl9JTkVUOwogICAgc2luLnNpbl9wb3J0ID0gaHRvbnMoMjIpOwogICAgc2luLnNpbl9hZGRy LnNfYWRkciA9IGhvc3RhZGRyOwogICAgaWYgKGNvbm5lY3Qoc29jaywgKHN0cnVjdCBzb2NrYWRk ciopKCZzaW4pLAogICAgICAgICAgICBzaXplb2Yoc3RydWN0IHNvY2thZGRyX2luKSkgIT0gMCkg ewogICAgICAgIGZwcmludGYoc3RkZXJyLCAiZmFpbGVkIHRvIGNvbm5lY3QhXG4iKTsKICAgICAg ICByZXR1cm4gLTE7CiAgICB9CgogICAgLyogQ3JlYXRlIGEgc2Vzc2lvbiBpbnN0YW5jZQogICAg ICovCiAgICBzZXNzaW9uID0gbGlic3NoMl9zZXNzaW9uX2luaXQoKTsKICAgIGlmKCFzZXNzaW9u KQogICAgICAgIHJldHVybiAtMTsKCiAgICAvKiAuLi4gc3RhcnQgaXQgdXAuIFRoaXMgd2lsbCB0 cmFkZSB3ZWxjb21lIGJhbm5lcnMsIGV4Y2hhbmdlIGtleXMsCiAgICAgKiBhbmQgc2V0dXAgY3J5 cHRvLCBjb21wcmVzc2lvbiwgYW5kIE1BQyBsYXllcnMKICAgICAqLwogICAgcmMgPSBsaWJzc2gy X3Nlc3Npb25faGFuZHNoYWtlKHNlc3Npb24sIHNvY2spOwogICAgaWYocmMpIHsKICAgICAgICBm cHJpbnRmKHN0ZGVyciwgIkZhaWx1cmUgZXN0YWJsaXNoaW5nIFNTSCBzZXNzaW9uOiAlZFxuIiwg cmMpOwogICAgICAgIHJldHVybiAtMTsKICAgIH0KCiAgICAvKiBBdCB0aGlzIHBvaW50IHdlIGhh dm4ndCB5ZXQgYXV0aGVudGljYXRlZC4gIFRoZSBmaXJzdCB0aGluZyB0byBkbwogICAgICogaXMg Y2hlY2sgdGhlIGhvc3RrZXkncyBmaW5nZXJwcmludCBhZ2FpbnN0IG91ciBrbm93biBob3N0cyBZ b3VyIGFwcAogICAgICogbWF5IGhhdmUgaXQgaGFyZCBjb2RlZCwgbWF5IGdvIHRvIGEgZmlsZSwg bWF5IHByZXNlbnQgaXQgdG8gdGhlCiAgICAgKiB1c2VyLCB0aGF0J3MgeW91ciBjYWxsCiAgICAg Ki8KICAgIGZpbmdlcnByaW50ID0gbGlic3NoMl9ob3N0a2V5X2hhc2goc2Vzc2lvbiwgTElCU1NI Ml9IT1NUS0VZX0hBU0hfU0hBMSk7CiAgICBmcHJpbnRmKHN0ZGVyciwgIkZpbmdlcnByaW50OiAi KTsKICAgIGZvcihpID0gMDsgaSA8IDIwOyBpKyspIHsKICAgICAgICBmcHJpbnRmKHN0ZGVyciwg IiUwMlggIiwgKHVuc2lnbmVkIGNoYXIpZmluZ2VycHJpbnRbaV0pOwogICAgfQogICAgZnByaW50 ZihzdGRlcnIsICJcbiIpOwoKICAgIGlmIChhdXRoX3B3KSB7CiAgICAgICAgLyogV2UgY291bGQg YXV0aGVudGljYXRlIHZpYSBwYXNzd29yZCAqLwogICAgICAgIGlmIChsaWJzc2gyX3VzZXJhdXRo X3Bhc3N3b3JkKHNlc3Npb24sIHVzZXJuYW1lLCBwYXNzd29yZCkpIHsKICAgICAgICAgICAgZnBy aW50ZihzdGRlcnIsICJBdXRoZW50aWNhdGlvbiBieSBwYXNzd29yZCBmYWlsZWQuXG4iKTsKICAg ICAgICAgICAgZ290byBzaHV0ZG93bjsKICAgICAgICB9CiAgICB9IGVsc2UgewogICAgICAgIC8q IE9yIGJ5IHB1YmxpYyBrZXkgKi8KICAgICAgICBpZiAobGlic3NoMl91c2VyYXV0aF9wdWJsaWNr ZXlfZnJvbWZpbGUoc2Vzc2lvbiwgdXNlcm5hbWUsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAiL2hvbWUvdXNlcm5hbWUvLnNzaC9pZF9yc2EucHViIiwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICIvaG9tZS91c2VybmFtZS8uc3NoL2lkX3JzYSIsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICBwYXNzd29yZCkpIHsKICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJcdEF1dGhl bnRpY2F0aW9uIGJ5IHB1YmxpYyBrZXkgZmFpbGVkXG4iKTsKICAgICAgICAgICAgZ290byBzaHV0 ZG93bjsKICAgICAgICB9CiAgICB9CgogICAgLyogU2VuZCBhIGZpbGUgdmlhIHNjcC4gVGhlIG1v ZGUgcGFyYW1ldGVyIG11c3Qgb25seSBoYXZlIHBlcm1pc3Npb25zISAqLwogICAgY2hhbm5lbCA9 IGxpYnNzaDJfc2NwX3NlbmQoc2Vzc2lvbiwgc2NwcGF0aCwgZmlsZWluZm8uc3RfbW9kZSAmIDA3 NzcsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodW5zaWduZWQgbG9uZylmaWxlaW5m by5zdF9zaXplKTsKCiAgICBpZiAoIWNoYW5uZWwpIHsKICAgICAgICBjaGFyICplcnJtc2c7CiAg ICAgICAgaW50IGVycmxlbjsKICAgICAgICBpbnQgZXJyID0gbGlic3NoMl9zZXNzaW9uX2xhc3Rf ZXJyb3Ioc2Vzc2lvbiwgJmVycm1zZywgJmVycmxlbiwgMCk7CiAgICAgICAgZnByaW50ZihzdGRl cnIsICJVbmFibGUgdG8gb3BlbiBhIHNlc3Npb246ICglZCkgJXNcbiIsIGVyciwgZXJybXNnKTsK ICAgICAgICBnb3RvIHNodXRkb3duOwogICAgfQoKICAgIGZwcmludGYoc3RkZXJyLCAiU0NQIHNl c3Npb24gd2FpdGluZyB0byBzZW5kIGZpbGVcbiIpOwogICAgZG8gewogICAgICAgIG5yZWFkID0g ZnJlYWQobWVtLCAxLCBzaXplb2YobWVtKSwgbG9jYWwpOwogICAgICAgIGlmIChucmVhZCA8PSAw KSB7CiAgICAgICAgICAgIC8qIGVuZCBvZiBmaWxlICovCiAgICAgICAgICAgIGJyZWFrOwogICAg ICAgIH0KICAgICAgICBwdHIgPSBtZW07CgogICAgICAgIGRvIHsKICAgICAgICAgICAgLyogd3Jp dGUgdGhlIHNhbWUgZGF0YSBvdmVyIGFuZCBvdmVyLCB1bnRpbCBlcnJvciBvciBjb21wbGV0aW9u ICovCiAgICAgICAgICAgIHJjID0gbGlic3NoMl9jaGFubmVsX3dyaXRlKGNoYW5uZWwsIHB0ciwg bnJlYWQpOwogICAgICAgICAgICBpZiAocmMgPCAwKSB7CiAgICAgICAgICAgICAgICBmcHJpbnRm KHN0ZGVyciwgIkVSUk9SICVkXG4iLCByYyk7CiAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgfQogICAgICAgICAgICBlbHNlIHsKICAgICAgICAgICAgICAgIC8qIHJjIGluZGljYXRl cyBob3cgbWFueSBieXRlcyB3ZXJlIHdyaXR0ZW4gdGhpcyB0aW1lICovCiAgICAgICAgICAgICAg ICBwdHIgKz0gcmM7CiAgICAgICAgICAgICAgICBucmVhZCAtPSByYzsKICAgICAgICAgICAgfQog ICAgICAgIH0gd2hpbGUgKG5yZWFkKTsKCiAgICB9IHdoaWxlICgxKTsKICAgIAogICAgZnByaW50 ZihzdGRlcnIsIlNlbmQgYSAwIHRvIGluZGljYXRlIHRyYW5zZmVyIGNvbXBsZXRlXG4iKTsKICAg IG1lbVswXSA9IDA7CiAgICByYyA9IGxpYnNzaDJfY2hhbm5lbF93cml0ZShjaGFubmVsLG1lbSwx KTsKICAgIGlmIChyYyA8PSAwKQogICAgICAgIGZwcmludGYoc3RkZXJyLCAiRVJST1IgJWRcbiIs IHJjKTsKICAgIGZwcmludGYoc3RkZXJyLCJXYWl0aW5nIGZvciB0cmFuc2ZlciBzdGF0dXNcbiIp OwogICAgcmMgPSBsaWJzc2gyX2NoYW5uZWxfcmVhZChjaGFubmVsLG1lbSwxKTsKICAgIHdoaWxl IChyYyA9PSBMSUJTU0gyX0VSUk9SX0VBR0FJTikKICAgICAgcmMgPSBsaWJzc2gyX2NoYW5uZWxf cmVhZChjaGFubmVsLG1lbSwxKTsKCiAgICBpZiAocmMgPCAwKQogICAgICAgIGZwcmludGYoc3Rk ZXJyLCAiRVJST1IgJWRcbiIsIHJjKTsKICAgIGVsc2UgaWYgKG1lbVswXSAhPSAwKSB7CiAgICAg ICAgcmMgPSBsaWJzc2gyX2NoYW5uZWxfcmVhZChjaGFubmVsLCBtZW0sIDEwMjQpOwogICAgICAg IGlmIChyYyA+IDApewogICAgICAgICAgICBtZW1bcmMgLSAxXSA9IDA7CiAgICAgICAgICAgIGZw cmludGYoc3RkZXJyLCJUcmFuc2ZlciBzdGF0dXM6ICVzXG4iLG1lbSk7CiAgICAgICAgfQogICAg fQogICAgZWxzZQogICAgICAgIGZwcmludGYoc3RkZXJyLCJUcmFuc2ZlciBzdGF0dXM6IENvbXBs ZXRlXG4iKTsKCiAgICBmcHJpbnRmKHN0ZGVyciwgIlNlbmRpbmcgRU9GXG4iKTsKICAgIGxpYnNz aDJfY2hhbm5lbF9zZW5kX2VvZihjaGFubmVsKTsKCiAgICBmcHJpbnRmKHN0ZGVyciwgIldhaXRp bmcgZm9yIEVPRlxuIik7CiAgICBsaWJzc2gyX2NoYW5uZWxfd2FpdF9lb2YoY2hhbm5lbCk7Cgog ICAgZnByaW50ZihzdGRlcnIsICJXYWl0aW5nIGZvciBjaGFubmVsIHRvIGNsb3NlXG4iKTsKICAg IGxpYnNzaDJfY2hhbm5lbF93YWl0X2Nsb3NlZChjaGFubmVsKTsKCiAgICBsaWJzc2gyX2NoYW5u ZWxfZnJlZShjaGFubmVsKTsKICAgIGNoYW5uZWwgPSBOVUxMOwoKIHNodXRkb3duOgoKICAgIGlm KHNlc3Npb24pIHsKICAgICAgICBsaWJzc2gyX3Nlc3Npb25fZGlzY29ubmVjdChzZXNzaW9uLCAi Tm9ybWFsIFNodXRkb3duLCBUaGFuayB5b3UgZm9yIHBsYXlpbmciKTsKICAgICAgICBsaWJzc2gy X3Nlc3Npb25fZnJlZShzZXNzaW9uKTsKICAgIH0KI2lmZGVmIFdJTjMyCiAgICBjbG9zZXNvY2tl dChzb2NrKTsKI2Vsc2UKICAgIGNsb3NlKHNvY2spOwojZW5kaWYKICAgIGlmIChsb2NhbCkKICAg ICAgICBmY2xvc2UobG9jYWwpOwogICAgZnByaW50ZihzdGRlcnIsICJhbGwgZG9uZVxuIik7Cgog ICAgbGlic3NoMl9leGl0KCk7CgogICAgcmV0dXJuIDA7Cn0K ------------246-1415092066933-1 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== ------------246-1415092066933-1-- From libssh2-devel-bounces@cool.haxx.se Tue Nov 4 21:17:44 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sA4KHEMK029853; Tue, 4 Nov 2014 21:17:38 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sA4KHCE9029662 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 4 Nov 2014 21:17:12 +0100 Received: (qmail 13753 invoked by uid 501); 4 Nov 2014 20:17:11 -0000 Message-ID: <20141104201711.13752.qmail@stuge.se> Date: Tue, 4 Nov 2014 21:17:11 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: scp_write example is incomplete. Mail-Followup-To: libssh2-devel@cool.haxx.se References: <1415092066933.16274.248@webmail7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1415092066933.16274.248@webmail7> X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id sA4KHEMK029853 Hej Frasse, Frasse wrote: > I am attaching a modified version of the example that writes out > the error message to stderr. Could I ask you to send a unified diff, ideally the output from git format-patch -1 once you've created a commit, so that we get the correct authorship in the repository history and a useful commit message. It also makes a significant difference for reviewing the change. Thank you! //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Nov 5 09:46:43 2014 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sA58kEVo011269; Wed, 5 Nov 2014 09:46:38 +0100 Received: from mailrelay11.public.one.com (mailrelay11.public.one.com [195.47.247.189]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id sA58kDp1008577 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 5 Nov 2014 09:46:13 +0100 X-HalOne-Cookie: 0799181f74e315207c09c3420385d577e5991f8b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fworld.se; s=20140924; h=from:reply-to:subject:date:message-id:to:mime-version:content-type: in-reply-to:references; bh=VWDsiSX4uepg3mNUvGFq/TmhX2BpExEw+V3ZNFie2/8=; b=txu2gPMyOyB0/vqZGKobuOFq6MAv8mx7IXav8aMwvqyLpl71Vgw2fV6+uoeHfo7Km8ObYZFhEMoDy Plu7Tz9y9ysaJv8/2eCnHOPYduHLlwoq3nd1RRg0fYz08raz6BGdjx4PoVxwtQnk2P3TJmJNa3uHLm qrfud3O6BjZmBMqI= Received: from webmail5 (unknown [10.246.6.5]) by smtpfilter3.public.one.com (Halon Mail Gateway) with SMTP for ; Wed, 5 Nov 2014 08:44:53 +0000 (GMT) X-Originating-IP: 81.170.150.37 User-Agent: One.com webmail 8.14.0 In-Reply-To: <20141104201711.13752.qmail@stuge.se> References: <20141104201711.13752.qmail@stuge.se> MIME-Version: 1.0 Message-ID: <1415177166683.37274.6166@webmail5> Date: Wed, 05 Nov 2014 08:46:06 GMT To: "libssh2 development" From: "Frasse" Subject: Re: scp_write example is incomplete. Content-Type: multipart/mixed; boundary="----------6164-1415177166683-1" X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.16 Precedence: list Reply-To: frasse@fworld.se, libssh2 development List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" This is a multipart message in MIME format. ------------6164-1415177166683-1 Content-Type: multipart/alternative; boundary="----------6164-1415177166683-2" ------------6164-1415177166683-2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi again. This is the requested file. /Frasse 4 november 2014, Peter Stuge skrev: > Hej Frasse, >=20 > Frasse wrote: > > I am attaching a modified version of the example that writes out > > the error message to stderr. > >=20 > Could I ask you to send a unified diff, ideally the output from git > format-patch -1 once you've created a commit, so that we get the > correct authorship in the repository history and a useful commit > message. It also makes a significant difference for reviewing the > change. >=20 >=20 > Thank you! >=20 >=20 > //Peter > _______________________________________________ > libssh2-devel > ------------6164-1415177166683-2 Content-Type: multipart/related; boundary="----------6164-1415177166683-3" ------------6164-1415177166683-3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8 Hi again.

This is the requested file.

/Frasse

4 november 2014, Peter Stuge <peter@stuge.se> skrev:

Hej Frasse,

Frasse wrote:
I am att= aching a modified version of the example that writes out
the error mes= sage to stderr.

Could I ask you to send a unified d= iff, ideally the output from git
format-patch -1 once you've created a= commit, so that we get the
correct authorship in the repository histo= ry and a useful commit
message. It also makes a significant difference= for reviewing the
change.


Thank you!


//Peter
_______________________________________________
libssh2= -devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-d= evel
------------6164-1415177166683-3-- ------------6164-1415177166683-2-- ------------6164-1415177166683-1 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Check-result-after-complete-transfer.patch" Content-Type: application/octet-stream; name="0001-Check-result-after-complete-transfer.patch" RnJvbSBiOTM0N2I4NzYwZGE1MTJjMjc5MDE2MGIwYjM2YmY2OTAzMDIxYzNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGcmFzc2UgPGZyYXNzZUBmd29ybGQuc2U+CkRhdGU6IFdlZCwg NSBOb3YgMjAxNCAwOTozNDo0NiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIENoZWNrIHJlc3VsdCBh ZnRlciBjb21wbGV0ZSB0cmFuc2ZlcgoKLS0tCiBleGFtcGxlL3NjcF93cml0ZS5jIHwgICAyMiAr KysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyks IDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZXhhbXBsZS9zY3Bfd3JpdGUuYyBiL2V4YW1w bGUvc2NwX3dyaXRlLmMKaW5kZXggYjM4MTU3Yi4uNDFjOGQ5NCAxMDA2NDQKLS0tIGEvZXhhbXBs ZS9zY3Bfd3JpdGUuYworKysgYi9leGFtcGxlL3NjcF93cml0ZS5jCkBAIC0xODYsNiArMTg2LDI4 IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAgICAgICAgIH0gd2hpbGUgKG5y ZWFkKTsKIAogICAgIH0gd2hpbGUgKDEpOworICAgIAorICAgIGZwcmludGYoc3RkZXJyLCJTZW5k IGEgMCB0byBpbmRpY2F0ZSB0cmFuc2ZlciBjb21wbGV0ZVxuIik7CisgICAgbWVtWzBdID0gMDsK KyAgICByYyA9IGxpYnNzaDJfY2hhbm5lbF93cml0ZShjaGFubmVsLG1lbSwxKTsKKyAgICBpZiAo cmMgPD0gMCkKKyAgICAgICAgZnByaW50ZihzdGRlcnIsICJFUlJPUiAlZFxuIiwgcmMpOworICAg IGZwcmludGYoc3RkZXJyLCJXYWl0aW5nIGZvciB0cmFuc2ZlciBzdGF0dXNcbiIpOworICAgIHJj ID0gbGlic3NoMl9jaGFubmVsX3JlYWQoY2hhbm5lbCxtZW0sMSk7CisgICAgd2hpbGUgKHJjID09 IExJQlNTSDJfRVJST1JfRUFHQUlOKQorICAgICAgcmMgPSBsaWJzc2gyX2NoYW5uZWxfcmVhZChj aGFubmVsLG1lbSwxKTsKKworICAgIGlmIChyYyA8IDApCisgICAgICAgIGZwcmludGYoc3RkZXJy LCAiRVJST1IgJWRcbiIsIHJjKTsKKyAgICBlbHNlIGlmIChtZW1bMF0gIT0gMCkgeworICAgICAg ICByYyA9IGxpYnNzaDJfY2hhbm5lbF9yZWFkKGNoYW5uZWwsIG1lbSwgMTAyNCk7CisgICAgICAg IGlmIChyYyA+IDApeworICAgICAgICAgICAgbWVtW3JjIC0gMV0gPSAwOworICAgICAgICAgICAg ZnByaW50ZihzdGRlcnIsIlRyYW5zZmVyIHN0YXR1czogJXNcbiIsbWVtKTsKKyAgICAgICAgfQor ICAgIH0KKyAgICBlbHNlCisgICAgICAgIGZwcmludGYoc3RkZXJyLCJUcmFuc2ZlciBzdGF0dXM6 IENvbXBsZXRlXG4iKTsKIAogICAgIGZwcmludGYoc3RkZXJyLCAiU2VuZGluZyBFT0ZcbiIpOwog ICAgIGxpYnNzaDJfY2hhbm5lbF9zZW5kX2VvZihjaGFubmVsKTsKLS0gCjEuNy4xCgo= ------------6164-1415177166683-1 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== ------------6164-1415177166683-1--