www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: Code style and project status

Re: Code style and project status

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 20 Mar 2019 15:28:38 +0100 (CET)

On Sun, 17 Mar 2019, Daniel Stenberg wrote:

> Some of the issues I found:

This is now merged.

With this, we should no longer land code that causes compiler warnings or code
style warnings as the CI will yell at us if we try.

I'm sure a few (most?) pull-requests now need to get rebased, but I think
that's a necessary price to pay. The upside is that they will also now get
checked much more critically and some of them will be get warnings to work on
- fully automatically.

'make checsrc' in the source root runs the style checker if you build with
configure. I might add a rule to do it automatically for --enable-debug builds
in a future. That's how I do it in curl and I find it convenient and really
helps to write code to stick to the style.

I would appreciate some help in generating the similar make target made for
cmake builds, as I still lack basic cmake skills... :-/

-- 
  / daniel.haxx.se
_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2019-03-20

the libssh2 team