I first have built OpenSSL (1.1.0.c, which built fine), then tried to build libssh2. Libssh2 (1.8.0) is configured with:
CDPATH= cd /vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0; CC=gcc CFLAGS=" -m64 -march=corei7 -mmmx -msse -msse2 -msse3 -msse4 -mfpmath=sse " MAKEFLAGS= MFLAGS= ./configure --prefix=/vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0/build --without-libz --with-openssl --with-libssl-prefix=/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build
The output of configure is then:
checking whether to enable maintainer-specific portions of Makefiles... no
checking whether make supports nested variables... yes
checking for sed... /usr/bin/sed
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking libssh2 version... 1.8.0
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
configure: autobuild project... libssh2
configure: autobuild revision... 1.8.0
configure: autobuild hostname... nlbavlsm3.infor.com
configure: autobuild timestamp... 20170123-084611
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for long long... yes
checking if _REENTRANT is already defined... no
checking if _REENTRANT is actually needed... no
checking if _REENTRANT is onwards defined... no
checking for library containing socket... none required
checking for library containing inet_addr... none required
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking whether ln -s works... yes
checking whether make sets $(MAKE)... (cached) yes
checking for sshd... /usr/sbin/sshd
checking how to print strings... printf
checking for a sed that does not truncate output... (cached) /usr/bin/sed
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... dlltool
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /usr/bin/dd
checking how to truncate binary pipes... /usr/bin/dd bs=4096 count=1
checking for mt... no
checking if : is a manifest tool... no
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... no
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking whether byte ordering is bigendian... no
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking for ld used by GCC... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking for shared library run path origin... done
checking for libssl... no
configure: error: No crypto library found!
Try --with-libssl-prefix=PATH
or --with-libgcrypt-prefix=PATH
or --with-libmbedtls-prefix=PATH
or --with-wincng on Windows
While the required (but renamed as of openssl 1.1.0x) include files (only some are shown below) and libraries exist (in lib, not lib64):
ls /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/*
/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/bin:
c_rehash openssl
/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/include:
openssl
/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib:
engines-1.1 libcrypto.a libssl.a pkgconfig
ls /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/include/openssl/ssl*
/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/include/openssl/ssl.h /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/include/openssl/ssl3.h
/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/include/openssl/ssl2.h
See part of config.log:
configure:13832: result: no
configure:13858: checking for special C compiler options needed for large files
configure:13903: result: no
configure:13909: checking for _FILE_OFFSET_BITS value needed for large files
configure:13934: gcc -c -m64 -march=corei7 -mmmx -msse -msse2 -msse3 -msse4 -mfpmath=sse conftest.c >&5
configure:13934: $? = 0
configure:13966: result: no
configure:14103: checking for ld used by GCC
configure:14167: result: /usr/bin/ld -m elf_x86_64
configure:14174: checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld
configure:14187: result: yes
configure:14194: checking for shared library run path origin
configure:14207: result: done
configure:16943: checking for libssl
configure:16962: gcc -o conftest -m64 -march=corei7 -mmmx -msse -msse2 -msse3 -msse4 -mfpmath=sse conftest.c -lssl -lcrypto >&5
conftest.c:24:25: fatal error: openssl/ssl.h: No such file or directory
#include <openssl/ssl.h>
I was expecting here a -I flag to tell the compiler the path to the include files. When I add a set -x on line configure:16463., then I get the following output:
checking for shared library run path origin... done
+ test set = set
+ :
+ withval=no
+ use_libz=no
+ support_clear_memory=no
+ test none = none
+ test yes '!=' no
+ use_additional=yes
+ acl_save_prefix=/vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0/build
+ prefix=/vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0/build
+ acl_save_exec_prefix=NONE
+ exec_prefix=/vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0/build
+ eval 'additional_includedir="${prefix}/include"'
++ additional_includedir=/vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0/build/include
+ eval 'additional_libdir="${exec_prefix}/lib"'
++ additional_libdir=/vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0/build/lib
+ exec_prefix=NONE
+ prefix=/vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0/build
+ test set = set
+ :
+ withval=/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build
+ test X/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build = Xno
+ test X/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build = X
+ additional_includedir=/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/include
+ additional_libdir=/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib64
+ LIBSSL=
+ LTLIBSSL=
+ INCSSL=
+ LIBSSL_PREFIX=
+ rpathdirs=
+ ltrpathdirs=
+ names_already_handled=
+ names_next_round='ssl crypto'
+ test -n 'ssl crypto'
+ names_this_round='ssl crypto'
+ names_next_round=
+ for name in '$names_this_round'
+ already_handled=
+ test -z ''
+ names_already_handled=' ssl'
++ echo ssl
++ sed -e 'y|abcdefghijklmnopqrstuvwxyz./-|ABCDEFGHIJKLMNOPQRSTUVWXYZ___|'
+ uppername=SSL
+ eval 'value="$HAVE_LIBSSL"'
++ value=
+ test -n ''
+ found_dir=
+ found_la=
+ found_so=
+ found_a=
+ eval 'libname="lib$name"'
++ libname=libssl
+ test -n so
+ shrext=.so
+ test yes = yes
+ dir=/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib64
+ test -n so
+ test -f /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib64/libssl.so
+ test '$libname$shrext' = '$libname$shrext$versuffix'
+ eval 'library_names="$libname$shrext"'
++ library_names=libssl.so
+ for f in '$library_names'
+ test -f /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib64/libssl.so
+ test X = X
+ test -f /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib64/libssl.a
+ test X '!=' X
+ test X = X
+ test X '!=' X
+ LIBSSL=-lssl
+ LTLIBSSL=-lssl
+ for name in '$names_this_round'
+ already_handled=
+ for n in '$names_already_handled'
+ test ssl = crypto
+ test -z ''
+ names_already_handled=' ssl crypto'
++ echo crypto
++ sed -e 'y|abcdefghijklmnopqrstuvwxyz./-|ABCDEFGHIJKLMNOPQRSTUVWXYZ___|'
+ uppername=CRYPTO
+ eval 'value="$HAVE_LIBCRYPTO"'
++ value=
+ test -n ''
+ found_dir=
+ found_la=
+ found_so=
+ found_a=
+ eval 'libname="lib$name"'
++ libname=libcrypto
+ test -n so
+ shrext=.so
+ test yes = yes
+ dir=/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib64
+ test -n so
+ test -f /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib64/libcrypto.so
+ test '$libname$shrext' = '$libname$shrext$versuffix'
+ eval 'library_names="$libname$shrext"'
++ library_names=libcrypto.so
+ for f in '$library_names'
+ test -f /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib64/libcrypto.so
+ test X = X
+ test -f /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib64/libcrypto.a
+ test X '!=' X
+ test X = X
+ for x in '$LDFLAGS' '$LTLIBSSL'
+ acl_save_prefix=/vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0/build
+ prefix=/vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0/build
+ acl_save_exec_prefix=NONE
+ exec_prefix=/vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0/build
+ eval 'x="-lssl"'
++ x=-lssl
+ exec_prefix=NONE
+ prefix=/vobs/obj.RHAT7/thirdparty/libssh2/64bit/libssh2-1.8.0/build
+ case "$x" in
+ test X '!=' X
+ test X '!=' X
+ LIBSSL='-lssl -lcrypto'
+ LTLIBSSL='-lssl -lcrypto'
+ test -n ''
+ test X '!=' X
+ test X '!=' X
+ ac_save_CPPFLAGS=
+ printf '%s\n' 'configure:16945: checking for libssl'
+ printf %s 'checking for libssl... '
checking for libssl... + false
+ ac_save_LIBS=
+ LIBS=' -lssl -lcrypto'
+ cat confdefs.h -
+ ac_fn_c_try_link 16964
+ as_lineno=16964
+ as_lineno_stack=as_lineno_stack=
+ rm -f conftest.o conftest
+ ac_try='$CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $LIBS >&5'
+ case "(($ac_try" in
+ ac_try_echo='$CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $LIBS >&5'
+ eval 'ac_try_echo="$as_me:16964: $CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $LIBS >&5"'
++ ac_try_echo='configure:16964: gcc -o conftest -m64 -march=corei7 -mmmx -msse -msse2 -msse3 -msse4 -mfpmath=sse conftest.c -lssl -lcrypto >&5'
+ printf '%s\n' 'configure:16964: gcc -o conftest -m64 -march=corei7 -mmmx -msse -msse2 -msse3 -msse4 -mfpmath=sse conftest.c -lssl -lcrypto >&5'
+ ac_status=1
+ test -s conftest.err
+ grep -v '^ *+' conftest.err
+ cat conftest.er1
+ mv -f conftest.er1 conftest.err
+ printf '%s\n' 'configure:16964: $? = 1'
+ test 1 = 0
+ printf '%s\n' 'configure: failed program was:'
+ sed 's/^/| /' conftest.c
+ ac_retval=1
+ rm -rf conftest.dSYM conftest_ipa8_conftest.oo
+ eval as_lineno_stack=
++ as_lineno_stack=
+ unset as_lineno
+ as_fn_set_status 1
+ return 1
+ ac_cv_libssl=no
+ rm -f core conftest.err conftest.o conftest conftest.c
+ LIBS=
+ printf '%s\n' 'configure:16974: result: no'
+ printf '%s\n' no
no
+ test no = yes
+ HAVE_LIBSSL=no
Note the 'lib64' part in /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib64/libssl.a. This is unexpected for me, and probably incorrect in the configure script (additional_libdir="$withval/$acl_libdirstem" from configure:16521. I don't know why the configure script likes to take 'lib64', while there is no necessary relationship by a user provided prefix dir for OpenSSL and a system lib64 prefix (acl_libdirstem is set at line 14237, and is related to something else than OpenSSL, isn't it)?
Why is $acl_libdirstem used for OpenSSL (and also for some others, e.g. libbcrypt_prefix)?
Even replacing additional_libdir="$withval/$acl_libdirstem" by additional_libdir="$withval/lib" did not fully help. Now the libs are correctly set, but the include (-I flag) is still omitted, see configure output:
+ dir=/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib
+ test -n so
+ test -f /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libcrypto.so
+ test '$libname$shrext' = '$libname$shrext$versuffix'
+ eval 'library_names="$libname$shrext"'
++ library_names=libcrypto.so
+ for f in '$library_names'
+ test -f /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libcrypto.so
+ test X = X
+ test -f /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libcrypto.a
+ found_dir=/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib
+ found_a=/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libcrypto.a
+ test X/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib '!=' X
+ test -f /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libcrypto.la
+ test X/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib = X
+ test X/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib '!=' X
+ LTLIBSSL='-L/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib -lssl -L/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib -lcrypto'
+ test X '!=' X
+ test X/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libcrypto.a '!=' X
+ LIBSSL='/vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libssl.a /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libcrypto.a'
+ additional_includedir=
+ case "$found_dir" in
+ test X '!=' X
+ test -n ''
+ test -n ''
+ test X '!=' X
+ test X '!=' X
+ ac_save_CPPFLAGS=
+ printf '%s\n' 'configure:16946: checking for libssl'
+ printf %s 'checking for libssl... '
checking for libssl... + false
+ ac_save_LIBS=
+ LIBS=' /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libssl.a /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libcrypto.a'
+ cat confdefs.h -
+ ac_fn_c_try_link 16965
+ as_lineno=16965
+ as_lineno_stack=as_lineno_stack=
+ rm -f conftest.o conftest
+ ac_try='$CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $LIBS >&5'
+ case "(($ac_try" in
+ ac_try_echo='$CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $LIBS >&5'
+ eval 'ac_try_echo="$as_me:16965: $CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $LIBS >&5"'
++ ac_try_echo='configure:16965: gcc -o conftest -m64 -march=corei7 -mmmx -msse -msse2 -msse3 -msse4 -mfpmath=sse conftest.c /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libssl.a /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libcrypto.a >&5'
+ printf '%s\n' 'configure:16965: gcc -o conftest -m64 -march=corei7 -mmmx -msse -msse2 -msse3 -msse4 -mfpmath=sse conftest.c /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libssl.a /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libcrypto.a >&5'
+ ac_status=1
+ test -s conftest.err
+ grep -v '^ *+' conftest.err
+ cat conftest.er1
+ mv -f conftest.er1 conftest.err
+ printf '%s\n' 'configure:16965: $? = 1'
+ test 1 = 0
+ printf '%s\n' 'configure: failed program was:'
+ sed 's/^/| /' conftest.c
+ ac_retval=1
+ rm -rf conftest.dSYM conftest_ipa8_conftest.oo
+ eval as_lineno_stack=
++ as_lineno_stack=
+ unset as_lineno
+ as_fn_set_status 1
+ return 1
+ ac_cv_libssl=no
+ rm -f core conftest.err conftest.o conftest conftest.c
+ LIBS=
+ printf '%s\n' 'configure:16975: result: no'
+ printf '%s\n' no
no
+ test no = yes
+ HAVE_LIBSSL=no
Config.log shows (i.e. correct library path now, but missing -I /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/include flag):
configure:16946: checking for libssl
configure:16965: gcc -o conftest -m64 -march=corei7 -mmmx -msse -msse2 -msse3 -msse4 -mfpmath=sse conftest.c /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libssl.a /vobs/obj.RHAT7/thirdparty/OpenSSL/64bit/openssl-1.1.0c/build/lib/libcrypto.a >&5
conftest.c:24:25: fatal error: openssl/ssl.h: No such file or directory
#include <openssl/ssl.h>
^
compilation terminated.
configure:16965: $? = 1
There are at least two issues: wrong LIB path and missng include path.
The missing include path is probably related to the reset of additional_includedir= directive in configure:16737 (and also using $acl_libdirstem). I'm not sure.
For me libssh2 is not very important on Linux/UNIX (I only use it for now on Windows). If I have time, I will perform more checking to figure out why the include path is not correctly added to the compiler flags.
Maybe you are already able to draw a conclusion on previous output.
Kees
-----Original Message-----
From: libssh2-devel [mailto:libssh2-devel-bounces_at_cool.haxx.se] On Behalf Of Daniel Stenberg
Sent: Thursday, January 19, 2017 13:50
To: libssh2 development <libssh2-devel_at_cool.haxx.se>
Subject: RE: support with openssl 1.1.0x
On Thu, 19 Jan 2017, Kees Dekker wrote:
> For 64-bit builds?
I do nothing but 64 bit builds.
> Will it help you if I provide the configure output (for RHAT7 in this case)?
I think the configure log might help *you* figure out why the script fails to
detect openssl.
Did something change in terms of placement of libraries when openssl was
bumped to 1.1.0 ? I've build libssh2 with openssl 64 bit since basically
forever.
--
/ daniel.haxx.se
_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2017-01-23