> It turned out that only uint64_t was problematic, because we define
> uint32_t to int. <
I hope that you mean that you defined uint32_t to unsigned int!
On Sun, Feb 14, 2016 at 5:38 PM, Alexander Lamaison <swish_at_lammy.co.uk>
> On 14 February 2016 at 20:04, Alexander Lamaison <swish_at_lammy.co.uk>
> > On 11 February 2016 at 15:13, Daniel Stenberg <daniel_at_haxx.se> wrote:
> >> On Mon, 2 Nov 2015, David Byron wrote:
> >>> Sorry to nag, but is the repo in a good state to release? Still hoping
> >>> for the large file stuff to get a little farther out in the world.
> >> I've merged the "fix SFTP" patches from the patient Jakob Egger into
> >> now. I _think_ we might be in a decent shape for release now.
> >> If you disagree, please tell us why. Also, please get the latest from
> >> and have a go at it to help us polish out the last few quirks before we
> >> ship.
> > I've just tested the latest from master and, unfortunately, it doesn't
> > compile with Visual Studio 2005. The new SFTP fix introduced uint64_t
> > and uint32_t, which aren't in C90. Please hold off releasing for now.
> I've pushed a fix for the build failure, and added more versions of VS
> to Appveyor so that we catch this automatically next time. It turned
> out that only uint64_t was problematic, because we define uint32_t to
> I've also finally resurrected my old test suite that was really good
> at catching SFTP stream errors. It confirmed that commit
> d754fee2f24565d8c89dc37a7f05ba1222a7bfc4 introduced data corruption,
> and that it has been fixed in latest master. So I think we're good to
> go for a release now.
> Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org)
> libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2016-02-19