Subject: Re: [PATCH] add function libssh2_session_set_last_error

Re: [PATCH] add function libssh2_session_set_last_error

From: Peter Stuge <peter_at_stuge.se>
Date: Mon, 26 Oct 2015 13:46:35 +0100

Daniel Stenberg wrote:
>> Thanks. I've pushed these to git.libssh2.org.
>
> But why push that to the deprecated git repo? Are you intending to keep
> your own fork there or why are you splintering the effort like that?
>
> The official libssh2 git repo is at https://github.com/libssh2/libssh2

I pushed to git.libssh2.org because I do not use GitHub, and I don't
think you should either. Read their terms. Apparently if someone sues
them for something you have done, you have to pay for their lawyers.
That's just one of the many silly things.

I don't intend on maintaining a fork and I'm not splintering the
effort. I've pushed an updaated (rewritten) branch to git.libssh2.org
now, with Salvador's commits on top of what's currently at GitHub.

> Also: that's a new API function but without any provided docs and I
> don't think we should merge new functions undocumented.

I squashed Salvador's documentation commits together with the commit
that adds the function.

//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2015-10-26