www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: CMake

Re: CMake

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Thu, 11 Dec 2014 12:48:10 +0100

On Thursday 11 December 2014 00:31:24 Alexander Lamaison wrote:
> On 8 December 2014 at 13:45, Kamil Dudka <kdudka_at_redhat.com> wrote:
> > On Saturday 06 December 2014 00:34:41 Alexander Lamaison wrote:
> >> tl;dr
> >> - A version of libssh2 using CMake is available at
> >>
> >> https://github.com/alamaison/libssh2/tree/cmake
> >>
> >> - Please test
> >
> > I have encountered a few minor issues:
> >
> > - The shared library is no longer versioned as it used to be. I have
> > hard-coded the version into src/CMakeLists.txt for now
>
> Fixed in d50c4f06a14fad1da34bc05af85602c5ce0e95eb
> https://github.com/alamaison/libssh2/commit/d50c4f06a14fad1da34bc05af85602c5
> ce0e95eb
> > - The file libssh2.pc is no longer generated with CMake. Is there any
> > plan
> > to restore this functionality?
>
> Fixed in 946ab802b9e79acdcc6c8e386b6510cd1f86d058
> https://github.com/alamaison/libssh2/commit/946ab802b9e79acdcc6c8e386b6510cd
> 1f86d058
>
> I noticed you had lib64 as the lib path. I had hardcoded 'lib' before
> so I changed to use GNUInstallDirs, which tries to do the right thing
> based on platform. Let me know if this causes any problems.

Thanks for the additional patches! I have incorporated them into my private
branch of the Fedora package:

http://pkgs.fedoraproject.org/cgit/libssh2.git/log/?h=private-kdudka-use-cmake-r0

Everything works just fine at first glance.

Kamil

> > I can help you with the rebase once there is agreement on the final
> > version.
> Thanks :)
>
> Alex
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2014-12-11

the libssh2 team