www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: CMake

Re: CMake

From: Kamil Dudka <kdudka_at_redhat.com>
Date: Tue, 09 Dec 2014 13:05:08 +0100

On Tuesday 09 December 2014 00:45:53 Alexander Lamaison wrote:
> > - The file libssh2.pc is no longer generated with CMake. Is there any
> > plan
> > to restore this functionality?
>
> CMake has a feature [1] that allows it to be used in place of
> pkg-config. In theory this removes the need for a .pc file, but, as
> you can see from the comments, the feature isn't universally popular.
> If you prefer, I can generate libssh2.pc from a template the way some
> other projects do.

We cannot just drop the file libssh2.pc in an update of the package in Fedora.
If we really want to get rid of it (so far there seems to be no consensus on
this topic), we need to go through a proper deprecation process. That is,
we need to provide both variants, document the current variant as deprecated,
and drop it after a few years from now.

> > - Man pages are not installed by CMake.
>
> Fixed:
> https://github.com/alamaison/libssh2/commit/ce9c01d4621d5ae020f4386d390860e
> 8c7aa553d

This works for me. Thanks!

> > - Before it goes to master, it would be good to merge some commits to make
> > the history easier to follow. Namely the unnecessary renames of libssh2.h
> > to libssh2.h.in and vice versa make the patchset difficult to apply on the
> > latest upstream release.
>
> I'll see what I can do to neaten it up.

I can help you with the rebase once there is agreement on the final version.

Kamil

> [1]
> https://blogs.kde.org/2011/11/09/cool-new-stuff-cmake-286-2-pkg-config-comp
> atible-mode-added-use-eg-autotools
>
> Alex
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2014-12-09

the libssh2 team