www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] wincng: Added explicit clear memory feature to WinCNG backend

Re: [PATCH] wincng: Added explicit clear memory feature to WinCNG backend

From: Marc Hoersken <info_at_marc-hoersken.de>
Date: Sat, 21 Jun 2014 15:24:44 +0200

Hi Peter,

On 20.06.2014 18:15, Peter Stuge wrote:
> I think a warning is appropriate when the --enable option was not
> explicitly specified.
>
> I think an error is neccessary when --enable *was* specified, but
> support is unavailable.

okay, but I am not sure how to differentiate the two scenarios. I tried
to implement the warning vs error condition, but now configure will
always display an error while configuring against openssl or libgcrypt
if --disable-clear-memory is not given. Please take a look at the
attached updated patch.

> Please don't add a new list of crypto backends to maintain. I'd
> suggest to instead introduce an abstraction such as
> $support_clear_memory which is set to no by default and set to yes by
> backends supporting this functionality.
>
> The above check would then inspect only that variable.

Good idea, implemented.

Best regards,
Marc

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

  • text/plain attachment: stored
Received on 2014-06-21

the libssh2 team