www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] wincng: Added explicit clear memory feature to WinCNG backend

Re: [PATCH] wincng: Added explicit clear memory feature to WinCNG backend

From: Peter Stuge <peter_at_stuge.se>
Date: Thu, 19 Jun 2014 19:57:08 +0200

Marc Hoersken wrote:
> Please review the new patch. Any feedback is welcome. I guess the patch
> should also include some warning about it only being available for
> Windows with WinCNG for now before being merged at the current stage of
> the implementation.

The configure switch should only be available when configuring with
wincng crypto.

If that is not possible (autoconf limitations) then enabling the
option should throw an error when this functionality is not available
in code.

Failing silently (ie. not securely zeroing memory) after a successful
configure of the library with the option enabled isn't really
acceptable IMO.

//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2014-06-19

the libssh2 team