www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] Do not expose private libraries nor link flags to clients of libssh2

Re: [PATCH] Do not expose private libraries nor link flags to clients of libssh2

From: Dan Fandrich <dan_at_coneharvesters.com>
Date: Mon, 19 May 2014 10:23:00 +0200

On Mon, May 19, 2014 at 10:09:16AM +0200, Mikhail Gusarov wrote:
> Reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747417
> ---
> libssh2.pc.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libssh2.pc.in b/libssh2.pc.in
> index 26d8a45..3a4f7b6 100644
> --- a/libssh2.pc.in
> +++ b/libssh2.pc.in
> @@ -12,6 +12,6 @@ URL: http://www.libssh2.org/
> Description: Library for SSH-based communication
> Version: @LIBSSH2VER@
> Requires.private: @LIBSREQUIRED@
> -Libs: -L${libdir} -lssh2 @LDFLAGS@ @LIBS@
> +Libs: -L${libdir} -lssh2
> Libs.private: @LIBS@
> Cflags: -I${includedir}
> --
> 1.8.5.3

The problem with this is that some of the flags may be necessary in order to
properly link clients with libssh2. It's probably more likely than not that
this isn't the case, but it may be safer to include them rather than not.
Packagers (like Debian) can apply this patch themselves when applicable to
their use case.

>>> Dan
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2014-05-19

the libssh2 team