This month's Index
Subject: RE: Suggested patches for WinCNG
RE: Suggested patches for WinCNG
From: Bob Kast <bob_2824_at_hotmail.com>
Date: Thu, 20 Mar 2014 14:29:26 -0400
> > Libssh2_priv.h:
Just above it is the exact same define, enclosed in #ifdef WIN32. I thought any Win compiler would define that. In any case, not important.
> > Wincng.c:
It is really preferable to do it here instead of the project file. For the LIB build, there is no linker so there is no place in the project file to put it. You'd need to add these libs to all OTHER projects that may include this library. I can certainly add beef up the #if so it only includes VS.
> > _libssh2_wincng_hash_update: the parameter needs to be const to match.
Unfortunately, there is no choice, besides making a copy of the data (which is definitely not worth it). It looks like the prototype for BCryptHashData() is incorrect in NOT labelling the pbInput parameter as const. Luckily, const issues in C are pretty easily overcome with a regular cast.
> I think we should rather wait for Alexander Lamaison's CMake files since they
I'm assuming that it will create makefiles, not VS project files, correct?