www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: Suggested patches for WinCNG

Re: Suggested patches for WinCNG

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 19 Mar 2014 22:48:24 +0100 (CET)

On Wed, 19 Mar 2014, Bob Kast wrote:

> Libssh2.h:
>
> In Windows, a socket is of type SOCKET, not int.

Correct of course. It was probably kept as an int to not risk changing the ABI
like your patched just did for win64, but then I guess the breakage is welcome
since it should make it work better... =)

Otherwise I noticed that you didn't follow the code style for all changes so
you've changed the indentation in several places.

> Libssh2.sln – solution file

What's the purpose of that?

-- 
  / daniel.haxx.se

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2014-03-19

the libssh2 team