www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] Added Windows Cryptography API: Next Generation backend

Re: [PATCH] Added Windows Cryptography API: Next Generation backend

From: Marc Hoersken <info_at_marc-hoersken.de>
Date: Sun, 16 Mar 2014 00:35:01 +0100

Hello everyone,

On 13.03.2014 20:39, Peter Stuge wrote:
> Yes, we should find a solution for this. Marc, did you notice if
> there *is* a reason not to always compile those first functions?
> Let's see if we can hammer this one out.

no, I did not find a reason not to always compile those functions.
Attached you will find patch 0002 which removes the ifdef-checks before
the WinCNG patch.

> Yes, I overlooked the define. :( Please have a look at the attached
> patch. If you think it's OK I'll push it.

It's much better than my initial patch, thanks. Since I had some trouble
with your patch using CRLF line endings for all files, even the
non-Windows specific ones, I reformatted the patch using msysgit and the
latest master branch with core.autocrlf being false. Please see attached
patch 0001.

I also found a warning while compiling with the win32/GNUmakefile,
please see attached patch 0003.

It would be great if you could merge these patches, so I can rebase the
WinCNG patch onto them. Thanks in advance.

Best regards,
Marc

  • text/plain attachment: stored
Received on 2014-03-16

the libssh2 team