www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [libssh2] #257: [PATCH] libssh2_session_free: infinite loop

Re: [libssh2] #257: [PATCH] libssh2_session_free: infinite loop

From: libssh2 Trac <trac_at_libssh2.stuge.se>
Date: Thu, 05 Sep 2013 18:02:48 -0000

#257: [PATCH] libssh2_session_free: infinite loop
-----------------------+-------------------
  Reporter: greg2001 | Owner:
      Type: defect | Status: new
  Priority: normal | Milestone: 1.4.3
 Component: API | Version: 1.4.2
Resolution: | Keywords:
Blocked By: | Blocks:
-----------------------+-------------------

Comment (by bagder):

 I think I would say that both fixes are needed:

 1 - _libssh2_channel_forward_cancel should free all data when it returns a
 failure (that isn't EAGAIN) and not leave anything "behind"

 2 - the loop needs to abort on any failure

 Thoughts?

-- 
Ticket URL: <https://trac.libssh2.org/ticket/257#comment:3>
libssh2 <https://trac.libssh2.org/>
C library for writing portable SSH2 clients
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2013-09-05

the libssh2 team