www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] Added Windows Cryptography API: Next Generation backend

Re: [PATCH] Added Windows Cryptography API: Next Generation backend

From: Marc Hoersken <info_at_marc-hoersken.de>
Date: Sun, 2 Jun 2013 10:21:53 +0200

Hi Peter,

2013/6/2 Peter Stuge <peter_at_stuge.se>:
> However, I have a few local commits which make configure.ac crypto
> library detection more general. Would you be up for rebasing onto
> them if I get them pushed? It shouldn't make a big difference for
> wincng, but it makes configure.ac a fair bit cleaner.

Yes, of course. I would also like to make a suggestion to the crypto
library detection and internal handling of definitions for each of
them. OpenSSL should really have it's own definition instead of
checking for the ones of other backends being unset. It could still be
setup as the default fallback if no other backend is configured, but
having to do one #ifdef each time should be much cleaner instead of
multiple #ifndef. This will also help me keep pem.c clean once I start
developing features for both libgcrypt and wincng.

What do you think? I could also try to do those improvements after you
pushed your changes and before wincng is merged.

Best regards,
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2013-06-02

the libssh2 team