www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] sftp: Add support for fsync (OpenSSH extension).

Re: [PATCH] sftp: Add support for fsync (OpenSSH extension).

From: Peter Stuge <peter_at_stuge.se>
Date: Tue, 16 Apr 2013 23:53:55 +0200

Richard W.M. Jones wrote:
> The patch (in the following email) adds fsync support to libssh2 via a
> new API function called 'libssh2_sftp_fsync'.
> *NOTE:* For this to work you will need a patched OpenSSH with an
> accepted-upstream-but-not-included patch that adds the
> fsync_at_openssh.com extension to OpenSSH sftp-server. For details see
> here:

I strongly dislike the absolute disconnect between the extremely
generic name libssh2_sftp_fsync() and the very opposite name
fsync_at_openssh.com - unless libssh2 will in the future use a heuristic
to determine which actual extension to use. I don't want that.

At a minimum, I'd like a follow up patch which changes the API name
to libssh2_sftp_fsync_openssh_com() or such..

libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2013-04-16

the libssh2 team