www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [libssh2] #256: many writes, congested link -> LIBSSH2_ERROR_BAD_USE, stuck

Re: [libssh2] #256: many writes, congested link -> LIBSSH2_ERROR_BAD_USE, stuck

From: libssh2 Trac <trac_at_libssh2.stuge.se>
Date: Tue, 05 Feb 2013 01:52:51 -0000

#256: many writes, congested link -> LIBSSH2_ERROR_BAD_USE, stuck
---------------------+-------------------
  Reporter: ncm | Owner:
      Type: defect | Status: new
  Priority: normal | Milestone: 1.4.3
 Component: misc | Version: 1.4.2
Resolution: | Keywords:
Blocked By: | Blocks:
---------------------+-------------------

Comment (by stuge):

 Replying to [comment:1 ncm]:
> Control messages are treated a little differently
> from payload messages.

 I don't like how the patch overloads a new situation onto _EAGAIN. All the
 hidden state within libssh2 is messy but I don't think it make sense to
 make it any worse.

 If I understand correctly the patch is for handling "internal" calls from
 other parts of libssh2. Please find a clean way to make that work instead
 - something that makes it clear what is actually going on. (Special
 handling because it is an internal call.) Perhaps by adding a new error
 code.

-- 
Ticket URL: <https://trac.libssh2.org/ticket/256#comment:2>
libssh2 <https://trac.libssh2.org/>
C library for writing portable SSH2 clients
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2013-02-05

the libssh2 team