This month's Index
Subject: Re: libssh2 MorphOS patch
Re: libssh2 MorphOS patch
From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 2 Aug 2012 00:00:38 +0200 (CEST)
On Wed, 1 Aug 2012, Leif Salomonsson wrote:
Thanks for your work!
> Because of collissions with bsdsocket send() and recv() functions, some
I don't get why those "collissions" cause any problems. Do you have them as
Your changes indicate there is something seriously wrong with your headers.
Further, your indents and white space changes were off. We use indent-level as
> Similar issue in agent.c, where ->connect() is changed to ->_connect_().
Perhaps, but you also changed the *actual* connect() call to _connect_() which
> Some blocking mode set/get changes/fixes in session.c.
I don't like how everything MorphOS there is within HAVE_IOCTLSOCKET_CASE when
... should rather be:
+#if defined(HAVE_IOCTLSOCKET_CASE) && (GETBLOCK == 0)
... I think should rather use #ifdef _MORPHOS or something as it seems more
BTW, MorphOS is not present here and I'd appreciate if you'd add it:
-- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-develReceived on 2012-08-02