www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] userauth: Allow authentication keys to be passed in memory

Re: [PATCH] userauth: Allow authentication keys to be passed in memory

From: Joe Turpin <joe.turpin_at_gmail.com>
Date: Mon, 19 Mar 2012 17:03:51 -0400

On Sat, Jan 21, 2012 at 5:23 PM, Daniel Stenberg <daniel_at_haxx.se> wrote:
> Hello,
>
> Thanks for the updated patch! This time I applied it, had a look and here
> are my comments:
>
> - memcpy_s() is not a function that exists portably, don't use it. I also
>  think you can skip checking memcpy()'s return code.
>
> - your new code produces lots of warnings and we're trying hard to not have
>  warnings (some are still there but lets not add new ones). ./configure
>  --enable-debug helps us see them.
>
> - also, where it is possible please keep the source lines shorter than 80
>  columns
>
> --
>
>  / daniel.haxx.se

Daniel,

Sorry for the delay. Life and work getting in the way as usual.

Patch email to follow shortly with fixes for the above.

--Joe

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2012-03-19

the libssh2 team