www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] Follow RFC4253 section 11.4

Re: [PATCH] Follow RFC4253 section 11.4

From: Henrik Nordström <henrik_at_henriknordstrom.net>
Date: Tue, 06 Mar 2012 13:04:40 +0100

mån 2012-03-05 klockan 22:36 -0700 skrev Steven Dake:
> On 03/05/2012 10:14 PM, Peter Stuge wrote:
> > Henrik Nordström wrote:
> >> For now we need your patch but with corrected comments and description.
> >> It's the wrong thing, but much better than doing nothing.
> >
> > Hm? I think doing the wrong thing isn't such a good idea?
> >
> > If we want to assist library users (I do) I think what we could do is
> > return an error for _keepalive_send() until it's safe to send one.
> >
> >
>
> It is keepalive_config which triggers the want_replys (keepalive_send
> doesn't take a want reply parameter)

No. That's the SSH_MSG_REQUEST_FAILURE problem and should be fixed so
that the keep-alive code picks up the response it asked for.

What we discuss here is the patch to ignore SSH_MSG_UNIMPLEMENTED.

Regards
Henrik

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2012-03-06

the libssh2 team