www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] Follow RFC4253 section 11.4

Re: [PATCH] Follow RFC4253 section 11.4

From: Henrik Nordström <henrik_at_henriknordstrom.net>
Date: Tue, 06 Mar 2012 13:01:27 +0100

tis 2012-03-06 klockan 06:14 +0100 skrev Peter Stuge:
> Henrik Nordström wrote:
> > For now we need your patch but with corrected comments and description.
> > It's the wrong thing, but much better than doing nothing.
>
> Hm? I think doing the wrong thing isn't such a good idea?

It is a small step towards a better result.

> If we want to assist library users (I do) I think what we could do is
> return an error for _keepalive_send() until it's safe to send one.

That too, but is unrelated other than attempting to send keep-alive too
early before protocol is active triggers the problem.

Regards
Henrik

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2012-03-06

the libssh2 team