www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] Follow RFC4253 section 11.4

Re: [PATCH] Follow RFC4253 section 11.4

From: Henrik Nordström <henrik_at_henriknordstrom.net>
Date: Thu, 01 Mar 2012 22:35:58 +0100

Regarding the patch to ignore SSH_MSG_UNIMPLEMENETD. While the patch and
reference to 4253 section 11.4 is clearly wrong for the reasons detaled
befire I think it may still be applied but with a slight addition of
debug messages alerting that the error was received.

This because there currently is no clean way to map
SSH_MSG_UNIMPLEMENTED back to the calling request. It's a kind of
special beast which libssh2 isn't quite prepared to handle in it's
current shape. We need to track sequence numbers a bit to handle this
proper as it's the only way to know which packet failed in a chain of
otherwise unanswered packets.

Or perhaps we should handle SSH_MSG_UNIMPLEMENTED as a fatal error
terminating the session?

REgards
Henrik

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2012-03-01

the libssh2 team