www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: [PATCH] Follow RFC4253 section 11.4

Re: [PATCH] Follow RFC4253 section 11.4

From: Henrik Nordström <henrik_at_henriknordstrom.net>
Date: Thu, 01 Mar 2012 01:12:36 +0100

ons 2012-02-29 klockan 16:43 -0700 skrev Steven Dake:

> Possible but at the moment the error isn't captured by any API resulting
> in a packet leak when this happens.

It should already get picked up via _libssh2_packet_requirev by the one
who sent the failing request.

> I am not quite sure how to return an error code in this condition, so
> not certain how to propose such a patch.

Do you have any evidence of SSH_MSG_UNIMPLEMENTED piling up? If so, in
response to what kind of requests?

This is not the same case as keepalive with want_reply set. The
keep-alive problem is libssh2_keepalive_send never trying to read the
response to the request it sent. It's state machine needs to be extended
to also read the reponse if want_reply is set.

Regards
Henrik

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2012-03-01

the libssh2 team