Subject: Re: timeouts in libssh2 blocking-mode

Re: timeouts in libssh2 blocking-mode

From: Matt Lilley <matt.lilley_at_securitease.com>
Date: Tue, 03 May 2011 13:02:16 +1200

Wow. I need more coffee, I think. I got one of the two, at least. 50%
isn't bad?
> Matt Lilley wrote:
>>> Btw, it doesn't make sense to have while(1) immediately preceded by a
>>> conditional break IMO.
>> Agreed, changed.
> ..
>> +++ b/src/session.h
>> @@ -53,15 +53,16 @@
> ..
>> - if(rc) \
>> - break; \
>> - } while(1)
> ..
>> + } while(rc); \
> I think you inverted the logic. Add the ! I wrote. :)
>
>
> //Peter
> _______________________________________________
> libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
>

-- 
_____________________________________________
Matt Lilley
Software Engineer
SecuritEase
Tel:    +64 4 912-2100
Fax:    +64 4 912-2101
E-mail: matt.lilley_at_securitease.com
Web:    http://www.securitease.com
_____________________________________________
This e-mail has passed our content security scan.
It is covered by the confidentiality clauses at http://www.securitease.com/content_and_confidentiality
Received on 2011-05-03