www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples | github

Archive Index This month's Index

Subject: Re: sftp_symlink() with too small buffer

Re: sftp_symlink() with too small buffer

From: Peter Stuge <peter_at_stuge.se>
Date: Mon, 3 Jan 2011 17:28:08 +0100

Daniel Stenberg wrote:
>>> I'd like to start having libssh2_sftp_symlink_ex() return
>>> LIBSSH2_ERROR_BUFFER_TOO_SMALL if the caller provides a too small
>>> buffer
>>
>> It's an API change, but I think it is one we need.
>
> Yes, it is a minor behavior modification but I can't think of another
> way to do it .. and I guess this change will only affect a small
> amount of users.

Yes, and it should be a safe change since it will at worst only
introduce a new error, pointing to code in libssh2 users that should
be fixed anyway.

> BTW, I noticed the same flaw and need in the sftp_readdir function,
> and I guess it may also be elsewhere once we start looking closer.

I say let's fix it everywhere.

//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2011-01-03

the libssh2 team