Subject: Re: [libssh2] #163: use libssh2_socket_t for socket type

Re: [libssh2] #163: use libssh2_socket_t for socket type

From: libssh2 Trac <trac_at_libssh2.stuge.se>
Date: Wed, 03 Mar 2010 23:15:37 -0000

#163: use libssh2_socket_t for socket type
--------------------+-------------------------------------------------------
 Reporter: sldr | Owner: bagder
     Type: defect | Status: assigned
 Priority: normal | Milestone:
Component: API | Version: 1.2.4
 Keywords: | Blocking:
Blockedby: |
--------------------+-------------------------------------------------------
Changes (by bagder):

  * owner: => bagder
  * status: new => assigned
  * version: 1.2.5 => 1.2.4

Comment:

 It can't include libssh2_priv.h since that is private and libssh2.h is a
 public header file.

 In general I think we've left the sockets as ints in the public prototypes
 just by being conservative in what we change.

 libssh2_poll() is marked "deprecated" anyway so fixing it isn't really
 worth it IMHO.

 libssh2_session_startup() however, is also using int for a socket and that
 is a function I think could be considered for fixing. We can't change it
 to 64 bits though since that would break the ABI.

-- 
Ticket URL: <http://libssh2.stuge.se/ticket/163#comment:2>
libssh2 <http://libssh2.stuge.se/>
C library for writing portable SSH2 clients
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-03-04