Subject: Re: Patch to use aes_*_ctr in newer versions of OpenSSL and #if LIBSSH2_DSA for more DSA-code

Re: Patch to use aes_*_ctr in newer versions of OpenSSL and #if LIBSSH2_DSA for more DSA-code

From: Peter Stuge <peter_at_stuge.se>
Date: Mon, 1 Mar 2010 15:54:29 +0100

Simon Josefsson wrote:
> >> > This is a patch to use OpenSSL's version of aes_*_ctr functions and to
> >> > not use DSA-code if not supported by OpenSSL
> >>
> >> Thanks. I applied your DSA-code patch as-is,
> >
> > Don't do this. DSA is required by RFC. Please have a look.
>
> What should libssh2 do if OpenSSL doesn't implement DSA? Refuse to
> build?

Yep, I feel pretty strongly that it's the only sane thing to do.

//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-03-01