Subject: Re: [libssh2] Wrap up a release!

Re: [libssh2] Wrap up a release!

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 17 Mar 2009 20:00:44 +0100 (CET)

On Tue, 17 Mar 2009, E L wrote:

> The past thread got sidetracked, so forgot about it. Is the bug clear?
> libssh2 uses errno, but win32 recv() and send() do not set errno, so libssh2
> code needs to set errno based on WSAGetLastError() after calling send() or
> recv().

Should we perhaps make a local wrapper for send() and recv() so that we could
put this logic only at a single spot?

> 3. consolidated the replicated code into one function so the exact same
> switch statement is not in 5 locations

Like into _libssh2_recv() and _libssh2_send() functions that sets errno?

-- 
  / daniel.haxx.se
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
libssh2-devel mailing list
libssh2-devel_at_lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel
Received on 2009-03-17