Subject: [libssh2] [ libssh2-Bugs-1701782 ] _MSC_VER==1310 and ssize_t etc.

[libssh2] [ libssh2-Bugs-1701782 ] _MSC_VER==1310 and ssize_t etc.

From: SourceForge.net <noreply_at_sourceforge.net>
Date: Thu, 05 Jul 2007 05:56:18 -0700

Bugs item #1701782, was opened at 2007-04-16 22:10
Message generated for change (Comment added) made by gknauf
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1701782&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Eberhard Mattes (em1)
Assigned to: Guenter Knauf (gknauf)
Summary: _MSC_VER==1310 and ssize_t etc.

Initial Comment:
The test for _MSC_VER in libssh2.h of 0.15-20070413 is wrong, compilation breaks for _MSC_VER==1310. That version of MSVC++ needs these type definitions:

typedef long ssize_t;
typedef unsigned int uint32_t;
typedef unsigned long long libssh2_uint64_t;
typedef long long libssh2_int64_t;

----------------------------------------------------------------------

>Comment By: Guenter Knauf (gknauf)
Date: 2007-07-05 14:56

Message:
Logged In: YES
user_id=670502
Originator: NO

this is now fixed in CVS. Please test ands report back. For now I've only
changed for _MSC_VER<=1310 since that is what we know for sure. If later
versions still need these defines please re-open the bug report.
Thanks!

----------------------------------------------------------------------

Comment By: Guenter Knauf (gknauf)
Date: 2007-07-03 19:56

Message:
Logged In: YES
user_id=670502
Originator: NO

I couldnt test with later MSVC versions than 6 when I added the typedefs:
http://libssh2.cvs.sourceforge.net/libssh2/libssh2/include/libssh2.h?view=log#rev1.66

I doubt that the __int64 type is gone with _MSC_VER >= 1300;
so I think we can probably simplify the patch like this:

--- libssh2.h.orig Mon Jun 18 20:39:12 2007
+++ libssh2.h Tue Jul 03 12:42:40 2007
@@ -64,13 +64,11 @@
 # include <sys/uio.h>
 #endif
 
-#if defined(LIBSSH2_WIN32) && defined(_MSC_VER) && (_MSC_VER < 1300)
+#if defined(LIBSSH2_WIN32) && defined(_MSC_VER) && (_MSC_VER < 1400)
 typedef unsigned __int64 libssh2_uint64_t;
 typedef __int64 libssh2_int64_t;
-#if (_MSC_VER <= 1200)
 typedef long ssize_t;
 typedef unsigned int uint32_t;
-#endif
 #else
 typedef unsigned long long libssh2_uint64_t;
 typedef long long libssh2_int64_t;

Guenter.

----------------------------------------------------------------------

Comment By: Eberhard Mattes (em1)
Date: 2007-07-01 13:03

Message:
Logged In: YES
user_id=680708
Originator: YES

Patch submitted (#1745991).

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2007-06-28 23:11

Message:
Logged In: YES
user_id=1110
Originator: NO

Can you please provide a complete patch that corrects the existing check
and adds working code for your version?

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1701782&group_id=125852

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
libssh2-devel mailing list
libssh2-devel_at_lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel
Received on 2007-07-05