www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples

Archive Index This month's Index

Subject: Re: libssh2 master 5ee3870 ssh2_echo: Value stored to 'exitcode' is never read

Re: libssh2 master 5ee3870 ssh2_echo: Value stored to 'exitcode' is never read

From: Peter Stuge <peter_at_stuge.se>
Date: Fri, 17 Dec 2010 07:16:21 +0100

libssh2_at_git.stuge.se wrote:
> commit 2165ceacd37d266fecb3d1298ea260ce0e334267
> Author: Daniel Stenberg <daniel_at_haxx.se>
..
> +++ b/src/libssh2_priv.h
> @@ -340,7 +339,7 @@ struct _LIBSSH2_CHANNEL
>
> libssh2_channel_data local, remote;
> /* Amount of bytes to be refunded to receive window (but not yet sent) */
> - unsigned long adjust_queue;
> + int adjust_queue;

Why make this signed? It's used in calculations in
_libssh2_channel_receive_window_adjust() where the other values
involved are always unsigned.

//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-12-17

the libssh2 team