www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples

Archive Index This month's Index

Subject: Re: libssh2 master aff9c82 channel_write: move some logic to _libssh2_channel_write

Re: libssh2 master aff9c82 channel_write: move some logic to _libssh2_channel_write

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Fri, 12 Nov 2010 20:16:11 +0100 (CET)

On Fri, 12 Nov 2010, Peter Stuge wrote:

>> @@ -1994,27 +1994,6 @@ channel_write(LIBSSH2_CHANNEL *channel, int stream_id,

> Losing this logging in channel_write() is a bit unfortunate, since there are
> multiple code paths leading to the function.

No, I recently introduced an additional function "layer" so
_libssh2_channel_write() is the function that is used all over internally and
channel_write() is only ever called from within _libssh2_channel_write().

I modified the logging to avoid excessive logging and unnecessary checks when
_libssh2_channel_write() loops and does multiple calls to channel_write().

-- 
  / daniel.haxx.se
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-11-12

the libssh2 team