Subject: Re: libssh2_error

Re: libssh2_error

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 22 Feb 2010 17:17:35 +0100 (CET)

On Mon, 22 Feb 2010, Alexander Lamaison wrote:

> I'm creating C++ bindings for libssh2 and, while working out the exception
> strategy, I noticed that some API calls set an error message using
> libssh2_error when they are about to return a failure code and others don't.
> Specifically, the knownhosts api never calls libssh2_error. I noticed that
> Daniel recently committed some changes to userauth that made all API calls
> use libssh2_error but do we have a coherent policy on this?

I agree that we need to make sure this is consistently done, and I think the
only sensible thing to do here is to make us ALWAYS use libssh2_error() when
we return errors.

(and yeah I did the knownhosts stuff so I am partly to blame for this...)

-- 
  / daniel.haxx.se
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-02-22