www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples

Archive Index This month's Index

Subject: Re: a libssh2 release soon

Re: a libssh2 release soon

From: Steven Van Ingelgem <steven_at_vaningelgem.be>
Date: Wed, 29 Jul 2009 10:55:19 +0200

2009/7/29 Daniel Stenberg <daniel_at_haxx.se>

> On Wed, 29 Jul 2009, Peter Stuge wrote:
>
> /* Actual I/O socket */
>>> - int socket_fd;
>>> + libssh2_socket_t socket_fd;
>>> int socket_state;
>>> int socket_block_directions;
>>> int socket_prev_blockstate; /* stores the state of the socket
>>> blockiness
>>>
>>
>> Other than that I kind of think this could go in before 1.2?
>>
>
> It could - if someone else than me pushes it and makes sure it is fine. I
> think there are more uses of sockets as int in the code though, (like maxfd
> in src/session.c) that should be fixed as well.
>
> The "not me" part is basically only because I'm trying to clear my table of
> libssh2-things to do before the release - I'm also working on an almost
> coordinated release of curl that will use the new knownhost API of libssh2
> 1.2...
>
> --
>
> / daniel.haxx.se
> _______________________________________________
> libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
>
Hereby attached a new patch with Peter's suggestions worked in as well as
checked the code for more socket-ints. It's possible I missed out some,
though I think most of them work on session->socket_fd.
Grtz,
Steven

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Received on 2009-07-29

the libssh2 team