[ libssh2-Bugs-2822910 ] send_exiting: debugdump wrong location

Bugs item #2822910, was opened at 2009-07-17 08:17
Message generated for change (Comment added) made by bagder
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2822910&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: misc
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Daniel Stenberg (bagder)
Summary: send_exiting: debugdump wrong location

Initial Comment:
In transport.c:send_existing() is the following statement

    debugdump(session, "libssh2_transport_write send()", &p->outbuf[p->osent],
              length);

at the wrong location. If debugging is enabled debugdump() may try to dump the memory at p->outbuf which is set to NULL in case the remainder of the package was sent. This cause a SigSegV.

Solution: move the statement before the "if (rc == length)"-block.

----------------------------------------------------------------------

Comment By: Daniel Stenberg (bagder)
Date: 2009-07-28 20:03

Message:
Thanks for your report and help in improving libssh2!

A fix has just been committed to the source code repo, this case is now
considered fixed and closed!

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2822910&group_id=125852
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2009-07-28