Re: Compiler warnings on HP Itanium

On Mon, 6 Apr 2009, Mononen Jussi wrote:

> "sftp.c", line 1993: warning #2068-D: integer conversion resulted in a
> change
> of sign
> retcode = -1;

> 'retcode' is defined as 'unsigned long'. Is this intentional?

No, it's a bug. I suggest this fix:

--- src/sftp.c 29 Mar 2009 22:09:29 -0000 1.72
+++ src/sftp.c 6 Apr 2009 13:20:28 -0000
@@ -1894,7 +1894,8 @@
  {
      LIBSSH2_CHANNEL *channel = sftp->channel;
      LIBSSH2_SESSION *session = channel->session;
- unsigned long data_len, retcode;
+ unsigned long data_len;
+ int retcode;
      ssize_t packet_len =
          source_filename_len + dest_filename_len + 17 + (sftp->version >=
                                                          5 ? 4 : 0);

-- 
  / daniel.haxx.se
------------------------------------------------------------------------------
_______________________________________________
libssh2-devel mailing list
libssh2-devel_at_lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel