[libssh2] [ libssh2-Bugs-2064371 ] Illegal '-' used in identification banner

Bugs item #2064371, was opened at 2008-08-21 09:46
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2064371&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: misc
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Illegal '-' used in identification banner

Initial Comment:
RFC 4253, section 4.2, states that:

        "Both the 'protoversion' and 'softwareversion' strings MUST consist of printable US-ASCII characters, with the exception of whitespace characters and the minus sign (-)."

However, the LIBSSH2_VERSION define in libssh2.h, which is used to build the 'softwareversion' part of LIBSSH2_SSH_BANNER and LIBSSH2_SSH_DEFAULT_BANNER, contains a '-' between the version number and the date.

I haven't encountered any clients that complain over this, but it is a violation of the RFC and also trivial to correct, so it should be.

I would suggest simply replacing the '-' with a '_'.

Bjrn Stenborg

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2064371&group_id=125852

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
libssh2-devel mailing list
libssh2-devel_at_lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel
Received on 2008-08-21