Re: [libssh2] Patch to report the remote error message when using scp

On Jul 5, 2007, at 12:30 AM, Gavrie Philipson wrote:

> Hi Jim,
>
> I'll admit that I'm not very familiar with the libssh2 code; this was
> just a first attempt.
> Now, I did test my patch on several remote hosts, not just on
> localhost, and it worked. Of course this may have been just a matter
> of luck, since all data could have been returned from the remote host
> (admittedly on the same LAN) in one packet.
>
> The question of termination of the message is indeed valid. I've taken
> a look at the OpenSSH code; it seems they are looking for a newline
> terminator as well, so that could be test best thing to do.
> As for the spec -- I've searched in vain for any kind of spec for the
> scp protocol (actually it's the rcp protocol in disguise) but could
> not find anything...

Looking more it seems that it probably shouldn't return
PACKET_EAGAIN, because we should be reading from a packet we already
received. But, I did a more complete patch that actually finds the
size of the error message.

Jim

--
/"\   ASCII Ribbon Campaign  .
\ / - NO HTML/RTF in e-mail  .
  X  - NO Word docs in e-mail .
/ \ -----------------------------------------------------------------
                      http://www.FreeBSD.org     The Power to Serve
jim@TheHousleys.Net  http://www.TheHousleys.net
---------------------------------------------------------------------
A: Yes.
| Q: Are you sure?
| | A: Because it reverses the logical flow of conversation.
| | | Q: Why is top posting frowned upon?

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

_______________________________________________
libssh2-devel mailing list
libssh2-devel_at_lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel