www.libssh2.org | Daily snapshots | Mailing list archive | Docs | Examples

Archive Index This month's Index

Subject: [libssh2] exported headers require libssh2 defines

[libssh2] exported headers require libssh2 defines

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Sat, 11 Nov 2006 13:41:14 +0100 (CET)

Hey

Some of the exported header files in include/ rely on defines that IMHO, they
better not.

For example, include/libssh2.h checks for LIBSSH2_WIN32 and LIBSSH2_DARWIN,
and it even does some typedefs and assumes the presence of long or or __int64
based on them! (Currently, the file size in sftp is the only place that needs
the int64_t type provided externally.)

I would like us to make the exported header files not depend on any defines
set in the (internal) libssh2 build process, at least unless those defines are
in a header file that also gets installed so that applications that include
these headers get the correct defines set.

If the header files really need to act differently due to different operating
systems or compilers or whatever, we should use the "correct" defines to base
such conditions on:

         http://predef.sourceforge.net/

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
libssh2-devel mailing list
libssh2-devel_at_lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel
Received on 2006-11-11

the libssh2 team